Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 151 | 0 | 0 | 1488 |
Files
org/flowfuse/base/Constants.java
| Error | Line |
|---|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
17
|
|
| Missing a Javadoc comment. |
17
|
|
| 'static' modifier out of order with the JLS suggestions. |
17
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
17
|
|
| Missing a Javadoc comment. |
19
|
|
| Line is longer than 80 characters. |
21
|
|
| Missing a Javadoc comment. |
21
|
|
| Line is longer than 80 characters. |
23
|
|
| Missing a Javadoc comment. |
23
|
|
| Line is longer than 80 characters. |
25
|
|
| Missing a Javadoc comment. |
25
|
|
| Line is longer than 80 characters. |
27
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
31
|
|
| Line is longer than 80 characters. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
35
|
org/flowfuse/base/dao/Dao.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line has trailing spaces. |
4
|
|
| Line is longer than 80 characters. |
21
|
|
| Missing a Javadoc comment. |
21
|
|
| Redundant 'public' modifier. |
21
|
|
| 'static' modifier out of order with the JLS suggestions. |
21
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
21
|
|
| Redundant 'public' modifier. |
29
|
|
| Redundant 'public' modifier. |
41
|
|
| Redundant 'public' modifier. |
47
|
|
| First sentence should end with a period. |
49
|
|
| Redundant 'public' modifier. |
54
|
org/flowfuse/base/dao/GroupDao.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
16
|
|
| Missing a Javadoc comment. |
16
|
|
| Redundant 'public' modifier. |
16
|
|
| 'static' modifier out of order with the JLS suggestions. |
16
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
16
|
|
| Missing a Javadoc comment. |
18
|
|
| Redundant 'public' modifier. |
18
|
|
| Missing a Javadoc comment. |
19
|
|
| Redundant 'public' modifier. |
19
|
|
| Missing a Javadoc comment. |
20
|
|
| Redundant 'public' modifier. |
20
|
org/flowfuse/base/dao/UserDao.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
16
|
|
| Missing a Javadoc comment. |
16
|
|
| Redundant 'public' modifier. |
16
|
|
| 'static' modifier out of order with the JLS suggestions. |
16
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
16
|
|
| Missing a Javadoc comment. |
18
|
|
| Redundant 'public' modifier. |
18
|
|
| Missing a Javadoc comment. |
19
|
|
| Redundant 'public' modifier. |
19
|
|
| Missing a Javadoc comment. |
20
|
|
| Redundant 'public' modifier. |
20
|
|
| Missing a Javadoc comment. |
21
|
|
| Redundant 'public' modifier. |
21
|
org/flowfuse/base/dao/WorkflowInstanceDao.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
14
|
|
| Line is longer than 80 characters. |
19
|
|
| Missing a Javadoc comment. |
19
|
|
| Redundant 'public' modifier. |
19
|
|
| 'static' modifier out of order with the JLS suggestions. |
19
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
19
|
|
| Missing a Javadoc comment. |
21
|
|
| Redundant 'public' modifier. |
21
|
|
| Missing a Javadoc comment. |
23
|
|
| Redundant 'public' modifier. |
23
|
|
| Missing a Javadoc comment. |
25
|
|
| Redundant 'public' modifier. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Redundant 'public' modifier. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Redundant 'public' modifier. |
29
|
|
| Missing a Javadoc comment. |
31
|
|
| Redundant 'public' modifier. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Redundant 'public' modifier. |
33
|
org/flowfuse/base/dao/hibernate/BaseDaoHibernate.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
23
|
|
| Missing a Javadoc comment. |
23
|
|
| 'static' modifier out of order with the JLS suggestions. |
23
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
23
|
|
| Missing a Javadoc comment. |
26
|
|
| Variable 'logger' must be private and have accessor methods. |
26
|
|
| Method 'saveObject' is not designed for extension - needs to be abstract, final or empty. |
31
|
|
| Parameter o should be final. |
31
|
|
| Method 'getObject' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Parameter clazz should be final. |
39
|
|
| Parameter id should be final. |
39
|
|
| Method 'getObjects' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Parameter clazz should be final. |
52
|
|
| Method 'removeObject' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
| Parameter clazz should be final. |
60
|
|
| Parameter id should be final. |
60
|
org/flowfuse/base/dao/hibernate/GroupDaoHibernate.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
19
|
|
| Line is longer than 80 characters. |
22
|
|
| 'static' modifier out of order with the JLS suggestions. |
22
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
22
|
|
| First sentence should end with a period. |
24
|
|
| Variable 'logger' must be private and have accessor methods. |
27
|
|
| Method 'getGroup' is not designed for extension - needs to be abstract, final or empty. |
30
|
|
| Missing a Javadoc comment. |
30
|
|
| Parameter id should be final. |
30
|
|
| Method 'saveGroup' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter group should be final. |
40
|
|
| Method 'removeGroup' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter id should be final. |
44
|
org/flowfuse/base/dao/hibernate/UserDaoHibernate.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
22
|
|
| Line is longer than 80 characters. |
25
|
|
| 'static' modifier out of order with the JLS suggestions. |
25
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
25
|
|
| First sentence should end with a period. |
27
|
|
| Variable 'logger' must be private and have accessor methods. |
30
|
|
| Method 'getUser' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter id should be final. |
33
|
|
| Method 'getUserByUserName' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Missing a Javadoc comment. |
43
|
|
| Parameter username should be final. |
43
|
|
| Method 'saveUser' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter user should be final. |
58
|
|
| Method 'removeUser' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter id should be final. |
62
|
org/flowfuse/base/dao/hibernate/WorkflowInstanceDaoHibernate.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
23
|
|
| Missing a Javadoc comment. |
29
|
|
| 'static' modifier out of order with the JLS suggestions. |
29
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
29
|
|
| Line is longer than 80 characters. |
30
|
|
| Missing a Javadoc comment. |
33
|
|
| Variable 'logger' must be private and have accessor methods. |
33
|
|
| Method 'getWorkflowInstance' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter id should be final. |
35
|
|
| Method 'getWorkflowInstanceByOswfId' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter oswfId should be final. |
46
|
|
| Method 'getWorkflowInstanceByKey' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Missing a Javadoc comment. |
61
|
|
| Parameter key should be final. |
61
|
|
| Method 'saveWorkflowInstance' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
|
| Parameter workItem should be final. |
76
|
|
| Method 'removeWorkflowInstance' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Missing a Javadoc comment. |
80
|
|
| Parameter id should be final. |
80
|
|
| Method 'query' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Missing a Javadoc comment. |
84
|
|
| Parameter filters should be final. |
84
|
|
| '{' should be on the previous line. |
94
|
|
| Method 'count' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Missing a Javadoc comment. |
129
|
|
| Parameter filter should be final. |
129
|
org/flowfuse/base/dao/hibernate/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/dao/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/frontend/BaseFormController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
23
|
|
| First sentence should end with a period. |
27
|
|
| Line is longer than 80 characters. |
30
|
|
| 'static' modifier out of order with the JLS suggestions. |
30
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
30
|
|
| First sentence should end with a period. |
32
|
|
| Variable 'logger' must be private and have accessor methods. |
35
|
|
| First sentence should end with a period. |
37
|
|
| Variable 'workItemManagementService' must be private and have accessor methods. |
40
|
|
| First sentence should end with a period. |
42
|
|
| Variable 'userManagementService' must be private and have accessor methods. |
45
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Missing a Javadoc comment. |
47
|
|
| Parameter request should be final. |
47
|
|
| Method 'getWorkItemManagementService' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Method 'setWorkItemManagementService' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter workItemManagementService should be final. |
63
|
|
| 'workItemManagementService' hides a field. |
63
|
|
| Method 'getUserManagementService' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Missing a Javadoc comment. |
67
|
|
| Method 'setUserManagementService' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Missing a Javadoc comment. |
71
|
|
| Parameter userService should be final. |
71
|
org/flowfuse/base/frontend/CommentActionForm.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
17
|
|
| Missing a Javadoc comment. |
17
|
|
| 'static' modifier out of order with the JLS suggestions. |
17
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
17
|
|
| Missing a Javadoc comment. |
20
|
|
| Variable 'logger' must be private and have accessor methods. |
20
|
|
| Missing a Javadoc comment. |
22
|
org/flowfuse/base/frontend/CreateWorkItemForm.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
28
|
|
| Line is longer than 80 characters. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| 'static' modifier out of order with the JLS suggestions. |
33
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
33
|
|
| Missing a Javadoc comment. |
36
|
|
| Variable 'logger' must be private and have accessor methods. |
36
|
|
| Missing a Javadoc comment. |
38
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Missing a Javadoc comment. |
43
|
|
| Parameter request should be final. |
43
|
|
| Method 'initBinder' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Missing a Javadoc comment. |
59
|
|
| Parameter request should be final. |
59
|
|
| Parameter binder should be final. |
60
|
|
| Method 'onSubmit' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Missing a Javadoc comment. |
68
|
|
| Parameter command should be final. |
68
|
org/flowfuse/base/frontend/EditDocumentForm.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
24
|
|
| Missing a Javadoc comment. |
24
|
|
| 'static' modifier out of order with the JLS suggestions. |
24
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
24
|
|
| Missing a Javadoc comment. |
27
|
|
| Variable 'logger' must be private and have accessor methods. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Line is longer than 80 characters. |
33
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter httpServletRequest should be final. |
33
|
|
| Line is longer than 80 characters. |
34
|
|
| ';' is not followed by whitespace. |
34
|
|
| Method 'onSubmit' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Missing a Javadoc comment. |
43
|
|
| Parameter command should be final. |
43
|
org/flowfuse/base/frontend/ExecuteActionForm.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
34
|
|
| Missing a Javadoc comment. |
34
|
|
| 'static' modifier out of order with the JLS suggestions. |
34
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
34
|
|
| Missing a Javadoc comment. |
37
|
|
| Variable 'logger' must be private and have accessor methods. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter request should be final. |
44
|
|
| Method 'processFormSubmission' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter request should be final. |
62
|
|
| Parameter response should be final. |
63
|
|
| Parameter command should be final. |
63
|
|
| Parameter e should be final. |
64
|
|
| Method 'onSubmit' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Missing a Javadoc comment. |
71
|
|
| Parameter command should be final. |
71
|
org/flowfuse/base/frontend/FrontendCommand.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
30
|
|
| Line is longer than 80 characters. |
33
|
|
| 'static' modifier out of order with the JLS suggestions. |
33
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
33
|
|
| First sentence should end with a period. |
35
|
|
| Variable 'logger' must be private and have accessor methods. |
38
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
52
|
|
| Missing a Javadoc comment. |
54
|
|
| Method 'getComment' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Missing a Javadoc comment. |
56
|
|
| Method 'setComment' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
| Missing a Javadoc comment. |
60
|
|
| Parameter comment should be final. |
60
|
|
| 'comment' hides a field. |
60
|
|
| Method 'getUser' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Missing a Javadoc comment. |
64
|
|
| Method 'setUser' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Missing a Javadoc comment. |
68
|
|
| Parameter user should be final. |
68
|
|
| 'user' hides a field. |
68
|
|
| Method 'getWorkflowAction' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Method 'setWorkflowAction' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
|
| Parameter workflowAction should be final. |
76
|
|
| 'workflowAction' hides a field. |
76
|
|
| Method 'getWorkItem' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Missing a Javadoc comment. |
80
|
|
| Method 'setWorkItem' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Missing a Javadoc comment. |
84
|
|
| Parameter workItem should be final. |
84
|
|
| 'workItem' hides a field. |
84
|
|
| Method 'getWorkList' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
| Missing a Javadoc comment. |
88
|
|
| Method 'setWorkList' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
| Missing a Javadoc comment. |
92
|
|
| Parameter workflows should be final. |
92
|
|
| Method 'getWorkListSize' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
| Missing a Javadoc comment. |
96
|
|
| Method 'getWorklistFilter' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
| Missing a Javadoc comment. |
100
|
|
| Method 'setWorklistFilter' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
| Missing a Javadoc comment. |
104
|
|
| Parameter worklistFilter should be final. |
104
|
|
| 'worklistFilter' hides a field. |
104
|
|
| Method 'getFilterAction' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
| Missing a Javadoc comment. |
108
|
|
| Method 'setFilterAction' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
| Missing a Javadoc comment. |
112
|
|
| Parameter filterAction should be final. |
112
|
|
| 'filterAction' hides a field. |
112
|
|
| Method 'getBuildInformation' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
| Missing a Javadoc comment. |
116
|
org/flowfuse/base/frontend/FrontendException.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
17
|
|
| Line is longer than 80 characters. |
20
|
|
| 'static' modifier out of order with the JLS suggestions. |
20
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
20
|
|
| First sentence should end with a period. |
22
|
|
| Variable 'logger' must be private and have accessor methods. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Parameter s should be final. |
27
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter s should be final. |
31
|
|
| Parameter throwable should be final. |
31
|
org/flowfuse/base/frontend/LoginLogoffController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
26
|
|
| First sentence should end with a period. |
30
|
|
| Line is longer than 80 characters. |
33
|
|
| 'static' modifier out of order with the JLS suggestions. |
33
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
33
|
|
| First sentence should end with a period. |
35
|
|
| Variable 'logger' must be private and have accessor methods. |
38
|
|
| Expected an @return tag. |
49
|
|
| Method 'login' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Parameter request should be final. |
49
|
|
| Expected @param tag for 'request'. |
49
|
|
| Parameter response should be final. |
50
|
|
| Expected @param tag for 'response'. |
50
|
|
| Expected an @return tag. |
62
|
|
| Method 'logout' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Parameter request should be final. |
62
|
|
| Expected @param tag for 'request'. |
62
|
|
| Parameter response should be final. |
63
|
|
| Expected @param tag for 'response'. |
63
|
|
| Line has trailing spaces. |
64
|
|
| Line is longer than 80 characters. |
73
|
org/flowfuse/base/frontend/ViewWorkItemController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
20
|
|
| Line is longer than 80 characters. |
25
|
|
| Missing a Javadoc comment. |
25
|
|
| 'static' modifier out of order with the JLS suggestions. |
25
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
25
|
|
| Missing a Javadoc comment. |
28
|
|
| Variable 'logger' must be private and have accessor methods. |
28
|
|
| Missing a Javadoc comment. |
30
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter request should be final. |
35
|
org/flowfuse/base/frontend/WorkListController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
29
|
|
| First sentence should end with a period. |
33
|
|
| Line is longer than 80 characters. |
36
|
|
| 'static' modifier out of order with the JLS suggestions. |
36
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
36
|
|
| First sentence should end with a period. |
38
|
|
| Variable 'logger' must be private and have accessor methods. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
49
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Method 'isFormSubmission' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter request should be final. |
58
|
|
| Conditional logic can be removed. |
59
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Missing a Javadoc comment. |
66
|
|
| Parameter request should be final. |
66
|
|
| Method 'initBinder' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
| Missing a Javadoc comment. |
96
|
|
| Parameter request should be final. |
96
|
|
| Parameter binder should be final. |
97
|
|
| Line is longer than 80 characters. |
112
|
|
| Line is longer than 80 characters. |
118
|
|
| Line is longer than 80 characters. |
127
|
|
| Line is longer than 80 characters. |
128
|
|
| Method 'onSubmit' is not designed for extension - needs to be abstract, final or empty. |
147
|
|
| Missing a Javadoc comment. |
147
|
|
| Parameter request should be final. |
147
|
|
| Parameter response should be final. |
148
|
|
| Parameter command should be final. |
149
|
|
| Parameter errors should be final. |
150
|
|
| '&&' should be on a new line. |
158
|
|
| '!=' should be on a new line. |
165
|
|
| Method 'getFilterManagementService' is not designed for extension - needs to be abstract, final or empty. |
180
|
|
| Missing a Javadoc comment. |
180
|
|
| Method 'setFilterManagementService' is not designed for extension - needs to be abstract, final or empty. |
184
|
|
| Missing a Javadoc comment. |
184
|
|
| Parameter filterManagementService should be final. |
185
|
|
| 'filterManagementService' hides a field. |
185
|
org/flowfuse/base/frontend/administration/SystemInformationForm.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
17
|
|
| Line is longer than 80 characters. |
22
|
|
| Missing a Javadoc comment. |
22
|
|
| 'static' modifier out of order with the JLS suggestions. |
22
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
22
|
|
| Missing a Javadoc comment. |
25
|
|
| Variable 'logger' must be private and have accessor methods. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter request should be final. |
32
|
org/flowfuse/base/frontend/reporting/ReportingOverviewForm.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
17
|
|
| Line is longer than 80 characters. |
22
|
|
| Missing a Javadoc comment. |
22
|
|
| 'static' modifier out of order with the JLS suggestions. |
22
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
22
|
|
| Missing a Javadoc comment. |
25
|
|
| Variable 'logger' must be private and have accessor methods. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter request should be final. |
32
|
org/flowfuse/base/frontend/support/MyDateSupport.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
19
|
|
| Line is longer than 80 characters. |
22
|
|
| 'static' modifier out of order with the JLS suggestions. |
22
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
22
|
|
| First sentence should end with a period. |
24
|
|
| Variable 'logger' must be private and have accessor methods. |
27
|
|
| Method 'getAsText' is not designed for extension - needs to be abstract, final or empty. |
29
|
|
| Missing a Javadoc comment. |
29
|
|
| Method 'setAsText' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter string should be final. |
35
|
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
36
|
org/flowfuse/base/frontend/support/displaytag/ExtendedDateFormatter.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
23
|
|
| First sentence should end with a period. |
27
|
|
| Line is longer than 80 characters. |
30
|
|
| 'static' modifier out of order with the JLS suggestions. |
30
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
30
|
|
| First sentence should end with a period. |
32
|
|
| Variable 'logger' must be private and have accessor methods. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| ')' is preceded with whitespace. |
57
|
|
| Method 'decorate' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
|
| Parameter o should be final. |
76
|
|
| '+' should be on a new line. |
78
|
|
| '!' is followed by whitespace. |
81
|
|
| '+' should be on a new line. |
82
|
org/flowfuse/base/frontend/support/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/model/Attachment.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - java.io.Serializable. |
11
|
|
| Line is longer than 80 characters. |
31
|
|
| Missing a Javadoc comment. |
31
|
|
| 'static' modifier out of order with the JLS suggestions. |
31
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
31
|
|
| Missing a Javadoc comment. |
34
|
|
| Variable 'logger' must be private and have accessor methods. |
34
|
|
| Variable 'attachment' must be private and have accessor methods. |
39
|
|
| Variable 'attacher' must be private and have accessor methods. |
44
|
|
| Parameter attacher should be final. |
51
|
|
| 'attacher' hides a field. |
51
|
|
| Expected @param tag for 'attacher'. |
51
|
|
| Parameter attachment should be final. |
51
|
|
| 'attachment' hides a field. |
51
|
|
| Expected @param tag for 'attachment'. |
51
|
|
| Method 'getAttachment' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Missing a Javadoc comment. |
56
|
|
| Method 'getAttacher' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
| Missing a Javadoc comment. |
60
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Missing a Javadoc comment. |
64
|
|
| Parameter o should be final. |
64
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Missing a Javadoc comment. |
68
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
org/flowfuse/base/model/BaseObject.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
19
|
|
| Line is longer than 80 characters. |
22
|
|
| 'static' modifier out of order with the JLS suggestions. |
22
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
22
|
|
| Expected an @return tag. |
31
|
|
| Parameter o should be final. |
31
|
|
| Expected @param tag for 'o'. |
31
|
|
| Expected an @return tag. |
40
|
|
| Expected an @return tag. |
49
|
org/flowfuse/base/model/Comment.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
22
|
|
| Line is longer than 80 characters. |
25
|
|
| 'static' modifier out of order with the JLS suggestions. |
25
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
25
|
|
| First sentence should end with a period. |
27
|
|
| Variable 'logger' must be private and have accessor methods. |
30
|
|
| Variable 'text' must be private and have accessor methods. |
55
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter id should be final. |
70
|
|
| 'id' hides a field. |
70
|
|
| Line is longer than 80 characters. |
80
|
|
| Method 'getWorkflowInstance' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Method 'setWorkflowInstance' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
| Missing a Javadoc comment. |
86
|
|
| Parameter workItem should be final. |
86
|
|
| 'workItem' hides a field. |
86
|
|
| Method 'getAuthor' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
| Method 'setAuthor' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
| Missing a Javadoc comment. |
106
|
|
| Parameter author should be final. |
106
|
|
| 'author' hides a field. |
106
|
|
| Method 'getCreationDate' is not designed for extension - needs to be abstract, final or empty. |
117
|
|
| Method 'setCreationDate' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
| Missing a Javadoc comment. |
121
|
|
| Parameter creationDate should be final. |
121
|
|
| 'creationDate' hides a field. |
121
|
|
| Method 'getText' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
| Method 'setText' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
| Missing a Javadoc comment. |
136
|
|
| Parameter text should be final. |
136
|
|
| 'text' hides a field. |
136
|
|
| Expected an @return tag. |
147
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
147
|
|
| Parameter o should be final. |
147
|
|
| Expected @param tag for 'o'. |
147
|
|
| Line is longer than 80 characters. |
157
|
|
| Avoid inline conditionals. |
157
|
|
| Line is longer than 80 characters. |
160
|
|
| Avoid inline conditionals. |
160
|
|
| Avoid inline conditionals. |
163
|
|
| Expected an @return tag. |
179
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
179
|
|
| '29' is a magic number. |
182
|
|
| Avoid inline conditionals. |
182
|
|
| '29' is a magic number. |
183
|
|
| Avoid inline conditionals. |
183
|
|
| '29' is a magic number. |
184
|
|
| Avoid inline conditionals. |
184
|
|
| Expected an @return tag. |
194
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
194
|
|
| '+' should be on a new line. |
195
|
|
| '+' should be on a new line. |
196
|
|
| '+' should be on a new line. |
197
|
|
| '+' should be on a new line. |
198
|
|
| '+' should be on a new line. |
199
|
|
| '+' should be on a new line. |
200
|
org/flowfuse/base/model/WorkItem.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Extra HTML tag found: </code> |
31
|
|
| Extra HTML tag found: </code> |
33
|
|
| First sentence should end with a period. |
44
|
|
| Line is longer than 80 characters. |
47
|
|
| 'static' modifier out of order with the JLS suggestions. |
47
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
47
|
|
| First sentence should end with a period. |
49
|
|
| Variable 'logger' must be private and have accessor methods. |
52
|
|
| First sentence should end with a period. |
54
|
|
| First sentence should end with a period. |
59
|
|
| First sentence should end with a period. |
64
|
|
| First sentence should end with a period. |
69
|
|
| First sentence should end with a period. |
75
|
|
| First sentence should end with a period. |
81
|
|
| Missing a Javadoc comment. |
87
|
|
| Method 'initializeWorkflow' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| '+' should be on a new line. |
98
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
| Missing a Javadoc comment. |
116
|
|
| Parameter id should be final. |
116
|
|
| 'id' hides a field. |
116
|
|
| Expected an @return tag. |
125
|
|
| Method 'getOswfId' is not designed for extension - needs to be abstract, final or empty. |
125
|
|
| Method 'setOswfId' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Missing a Javadoc comment. |
129
|
|
| Parameter oswfId should be final. |
129
|
|
| 'oswfId' hides a field. |
129
|
|
| Method 'getPayload' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
| Method 'setPayload' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
| Missing a Javadoc comment. |
149
|
|
| Parameter payload should be final. |
149
|
|
| 'payload' hides a field. |
149
|
|
| Method 'getComments' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
| Method 'setComments' is not designed for extension - needs to be abstract, final or empty. |
169
|
|
| Missing a Javadoc comment. |
169
|
|
| Parameter comments should be final. |
169
|
|
| 'comments' hides a field. |
169
|
|
| Method 'addComment' is not designed for extension - needs to be abstract, final or empty. |
173
|
|
| Missing a Javadoc comment. |
173
|
|
| Parameter comment should be final. |
173
|
|
| Method 'getWorkflow' is not designed for extension - needs to be abstract, final or empty. |
208
|
|
| Line is longer than 80 characters. |
213
|
|
| Method 'setWorkflow' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
| Parameter workflow should be final. |
220
|
|
| 'workflow' hides a field. |
220
|
|
| Expected an @return tag. |
231
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
231
|
|
| Parameter o should be final. |
231
|
|
| Expected @param tag for 'o'. |
231
|
|
| '?' should be on a new line. |
241
|
|
| Avoid inline conditionals. |
241
|
|
| ':' should be on a new line. |
242
|
|
| Expected an @return tag. |
256
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
256
|
|
| Avoid inline conditionals. |
257
|
|
| Expected an @return tag. |
266
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
266
|
|
| '+' should be on a new line. |
267
|
|
| '+' should be on a new line. |
268
|
|
| '+' should be on a new line. |
269
|
|
| '+' should be on a new line. |
270
|
|
| '+' should be on a new line. |
271
|
|
| '+' should be on a new line. |
272
|
org/flowfuse/base/model/Workflow.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
34
|
|
| Line is longer than 80 characters. |
37
|
|
| 'static' modifier out of order with the JLS suggestions. |
37
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
37
|
|
| First sentence should end with a period. |
39
|
|
| Variable 'logger' must be private and have accessor methods. |
42
|
|
| Missing a Javadoc comment. |
55
|
|
| Parameter workItem should be final. |
62
|
|
| 'workItem' hides a field. |
62
|
|
| Method 'getState' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Method 'getCurrentSteps' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Method 'getHistorySteps' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
| Method 'getAvailableActions' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
| Method 'getAvailableActions' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
| Parameter inputs should be final. |
150
|
|
| Method 'startWorkflow' is not designed for extension - needs to be abstract, final or empty. |
167
|
|
| Missing a Javadoc comment. |
167
|
|
| '2801' is a magic number. |
172
|
|
| Method 'executeWorkflowAction' is not designed for extension - needs to be abstract, final or empty. |
175
|
|
| Missing a Javadoc comment. |
175
|
|
| Parameter workflowAction should be final. |
175
|
|
| Parameter inputs should be final. |
176
|
|
| Method 'getWorkflowAction' is not designed for extension - needs to be abstract, final or empty. |
183
|
|
| Missing a Javadoc comment. |
183
|
|
| Parameter id should be final. |
183
|
|
| Expected an @return tag. |
194
|
|
| Method 'getWorkflowService' is not designed for extension - needs to be abstract, final or empty. |
194
|
|
| Method 'setWorkflowService' is not designed for extension - needs to be abstract, final or empty. |
202
|
|
| Parameter workflowService should be final. |
202
|
|
| 'workflowService' hides a field. |
202
|
|
| Expected @param tag for 'workflowService'. |
202
|
|
| Expected an @return tag. |
212
|
|
| Method 'getWorkflowManagementService' is not designed for extension - needs to be abstract, final or empty. |
212
|
|
| Method 'setWorkflowManagementService' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
| Parameter workItemManagementService should be final. |
221
|
|
| 'workItemManagementService' hides a field. |
221
|
|
| Expected @param tag for 'workItemManagementService'. |
221
|
org/flowfuse/base/model/WorkflowAction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
30
|
|
| Missing a Javadoc comment. |
30
|
|
| 'static' modifier out of order with the JLS suggestions. |
30
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
30
|
|
| Missing a Javadoc comment. |
33
|
|
| Variable 'logger' must be private and have accessor methods. |
33
|
|
| Variable 'comment' must be private and have accessor methods. |
36
|
|
| Parameter id should be final. |
54
|
|
| 'id' hides a field. |
54
|
|
| Parameter workflowDescriptor should be final. |
54
|
|
| 'workflowDescriptor' hides a field. |
54
|
|
| Expected @param tag for 'workflowDescriptor'. |
54
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Method 'getView' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Missing a Javadoc comment. |
80
|
org/flowfuse/base/model/WorkflowStep.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
30
|
|
| Line is longer than 80 characters. |
33
|
|
| 'static' modifier out of order with the JLS suggestions. |
33
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
33
|
|
| First sentence should end with a period. |
35
|
|
| Variable 'logger' must be private and have accessor methods. |
38
|
|
| Unclosed HTML tag found: <code>Step</step> instance. |
59
|
|
| Extra HTML tag found: </step> instance. |
59
|
|
| Extra HTML tag found: </step>. |
61
|
|
| Parameter step should be final. |
63
|
|
| 'step' hides a field. |
63
|
|
| Parameter workflowDescriptor should be final. |
63
|
|
| 'workflowDescriptor' hides a field. |
63
|
|
| Expected @param tag for 'workflowDescriptor'. |
63
|
|
| Method 'getCaller' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Method 'getFinishDate' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Method 'getStatus' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
| Method 'getAction' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
105
|
|
| Missing a Javadoc comment. |
105
|
|
| Missing a Javadoc comment. |
110
|
|
| 'if' is not followed by whitespace. |
111
|
org/flowfuse/base/model/filter/AbstractWorklistFilter.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
12
|
|
| First sentence should end with a period. |
16
|
|
| Line is longer than 80 characters. |
17
|
|
| 'static' modifier out of order with the JLS suggestions. |
17
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
17
|
|
| First sentence should end with a period. |
19
|
|
| Variable 'logger' must be private and have accessor methods. |
20
|
|
| Missing a Javadoc comment. |
22
|
|
| Missing a Javadoc comment. |
24
|
|
| Missing a Javadoc comment. |
26
|
|
| Method 'getOrderNumber' is not designed for extension - needs to be abstract, final or empty. |
28
|
|
| Missing a Javadoc comment. |
28
|
|
| Method 'setOrderNumber' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter orderNumber should be final. |
32
|
|
| 'orderNumber' hides a field. |
32
|
|
| Method 'getKey' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Missing a Javadoc comment. |
36
|
|
| Method 'setKey' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter key should be final. |
40
|
|
| 'key' hides a field. |
40
|
|
| Method 'getWhereConditions' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Method 'setWhereConditions' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter whereConditions should be final. |
48
|
|
| 'whereConditions' hides a field. |
48
|
org/flowfuse/base/model/filter/CheckboxFilter.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
19
|
|
| Line is longer than 80 characters. |
20
|
|
| 'static' modifier out of order with the JLS suggestions. |
20
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
20
|
|
| First sentence should end with a period. |
22
|
|
| Variable 'logger' must be private and have accessor methods. |
23
|
|
| Missing a Javadoc comment. |
25
|
|
| Method 'getParameters' is not designed for extension - needs to be abstract, final or empty. |
27
|
|
| Missing a Javadoc comment. |
27
|
|
| Method 'isSet' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Method 'isChecked' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| Method 'setChecked' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter checked should be final. |
41
|
|
| 'checked' hides a field. |
41
|
org/flowfuse/base/model/filter/DateRangeFilter.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
20
|
|
| Line is longer than 80 characters. |
21
|
|
| 'static' modifier out of order with the JLS suggestions. |
21
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
21
|
|
| First sentence should end with a period. |
23
|
|
| Variable 'logger' must be private and have accessor methods. |
24
|
|
| Missing a Javadoc comment. |
26
|
|
| Variable 'fromDate' must be private and have accessor methods. |
26
|
|
| Missing a Javadoc comment. |
28
|
|
| Variable 'toDate' must be private and have accessor methods. |
28
|
|
| Method 'getParameters' is not designed for extension - needs to be abstract, final or empty. |
30
|
|
| Missing a Javadoc comment. |
30
|
|
| Method 'isSet' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| Conditional logic can be removed. |
38
|
|
| Method 'getFromDate' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Missing a Javadoc comment. |
45
|
|
| Method 'setFromDate' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Missing a Javadoc comment. |
49
|
|
| Parameter fromDate should be final. |
49
|
|
| 'fromDate' hides a field. |
49
|
|
| Method 'getToDate' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
| Missing a Javadoc comment. |
53
|
|
| Method 'setToDate' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Missing a Javadoc comment. |
57
|
|
| Parameter toDate should be final. |
57
|
|
| 'toDate' hides a field. |
57
|
org/flowfuse/base/model/filter/SelectFilterOption.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
12
|
|
| First sentence should end with a period. |
16
|
|
| Line is longer than 80 characters. |
17
|
|
| 'static' modifier out of order with the JLS suggestions. |
17
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
17
|
|
| First sentence should end with a period. |
19
|
|
| Variable 'logger' must be private and have accessor methods. |
20
|
|
| Missing a Javadoc comment. |
22
|
|
| Missing a Javadoc comment. |
24
|
|
| Missing a Javadoc comment. |
26
|
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
28
|
|
| Missing a Javadoc comment. |
28
|
|
| Method 'getLabel' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Method 'setLabel' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter label should be final. |
36
|
|
| 'label' hides a field. |
36
|
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Missing a Javadoc comment. |
40
|
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter value should be final. |
44
|
|
| 'value' hides a field. |
44
|
|
| Method 'isSelected' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Missing a Javadoc comment. |
48
|
|
| Method 'setSelected' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter selected should be final. |
52
|
|
| 'selected' hides a field. |
52
|
org/flowfuse/base/model/filter/StepFilter.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
19
|
|
| Line is longer than 80 characters. |
20
|
|
| 'static' modifier out of order with the JLS suggestions. |
20
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
20
|
|
| First sentence should end with a period. |
22
|
|
| Variable 'logger' must be private and have accessor methods. |
23
|
|
| Missing a Javadoc comment. |
25
|
|
| Variable 'selectedSteps' must be private and have accessor methods. |
25
|
|
| Method 'getParameters' is not designed for extension - needs to be abstract, final or empty. |
27
|
|
| Missing a Javadoc comment. |
27
|
|
| Method 'isSet' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Method 'getSelectedSteps' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| Method 'setSelectedSteps' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter selectedSteps should be final. |
41
|
|
| 'selectedSteps' hides a field. |
41
|
org/flowfuse/base/model/filter/TextFilter.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
19
|
|
| Line is longer than 80 characters. |
20
|
|
| 'static' modifier out of order with the JLS suggestions. |
20
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
20
|
|
| First sentence should end with a period. |
22
|
|
| Variable 'logger' must be private and have accessor methods. |
23
|
|
| Missing a Javadoc comment. |
25
|
|
| Method 'getParameters' is not designed for extension - needs to be abstract, final or empty. |
27
|
|
| Missing a Javadoc comment. |
27
|
|
| Method 'isSet' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Conditional logic can be removed. |
34
|
|
| '(' is followed by whitespace. |
34
|
|
| ')' is preceded with whitespace. |
34
|
|
| Method 'getText' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Method 'setText' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Missing a Javadoc comment. |
45
|
|
| Parameter text should be final. |
45
|
|
| 'text' hides a field. |
45
|
org/flowfuse/base/model/filter/WorklistFilter.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
17
|
|
| Missing a Javadoc comment. |
17
|
|
| Redundant 'public' modifier. |
17
|
|
| 'static' modifier out of order with the JLS suggestions. |
17
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
17
|
|
| Missing a Javadoc comment. |
19
|
|
| Missing a Javadoc comment. |
21
|
|
| Missing a Javadoc comment. |
23
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
27
|
org/flowfuse/base/model/filter/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/model/right/SystemRight.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
18
|
|
| Line is longer than 80 characters. |
19
|
|
| 'static' modifier out of order with the JLS suggestions. |
19
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
19
|
|
| First sentence should end with a period. |
21
|
|
| Variable 'logger' must be private and have accessor methods. |
22
|
|
| Missing a Javadoc comment. |
24
|
|
| Missing a Javadoc comment. |
26
|
|
| Missing a Javadoc comment. |
28
|
|
| Parameter name should be final. |
28
|
|
| 'name' hides a field. |
28
|
|
| Parameter link should be final. |
28
|
|
| 'link' hides a field. |
28
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter name should be final. |
37
|
|
| 'name' hides a field. |
37
|
|
| Method 'getLink' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Method 'setLink' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Missing a Javadoc comment. |
45
|
|
| Parameter link should be final. |
45
|
|
| 'link' hides a field. |
45
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Missing a Javadoc comment. |
49
|
|
| Parameter o should be final. |
49
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
| Missing a Javadoc comment. |
53
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Missing a Javadoc comment. |
57
|
org/flowfuse/base/model/right/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/model/user/Group.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - java.util.List. |
10
|
|
| Unused import - java.util.ArrayList. |
11
|
|
| Unused import - java.io.Serializable. |
12
|
|
| First sentence should end with a period. |
22
|
|
| Line is longer than 80 characters. |
25
|
|
| 'static' modifier out of order with the JLS suggestions. |
25
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
25
|
|
| First sentence should end with a period. |
27
|
|
| Variable 'logger' must be private and have accessor methods. |
30
|
|
| Missing a Javadoc comment. |
32
|
|
| Variable 'id' must be private and have accessor methods. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| Variable 'name' must be private and have accessor methods. |
33
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter id should be final. |
44
|
|
| 'id' hides a field. |
44
|
|
| Expected an @return tag. |
51
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
51
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Missing a Javadoc comment. |
55
|
|
| Parameter name should be final. |
55
|
|
| 'name' hides a field. |
55
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Missing a Javadoc comment. |
59
|
|
| Parameter o should be final. |
59
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Missing a Javadoc comment. |
80
|
|
| '+' should be on a new line. |
81
|
|
| '+' should be on a new line. |
82
|
org/flowfuse/base/model/user/User.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
29
|
|
| Line is longer than 80 characters. |
32
|
|
| 'static' modifier out of order with the JLS suggestions. |
32
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
32
|
|
| First sentence should end with a period. |
34
|
|
| Variable 'logger' must be private and have accessor methods. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| Variable 'id' must be private and have accessor methods. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Variable 'username' must be private and have accessor methods. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Variable 'password' must be private and have accessor methods. |
41
|
|
| Missing a Javadoc comment. |
42
|
|
| Variable 'firstName' must be private and have accessor methods. |
42
|
|
| Missing a Javadoc comment. |
43
|
|
| Variable 'lastName' must be private and have accessor methods. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Variable 'email' must be private and have accessor methods. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Variable 'groups' must be private and have accessor methods. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Variable 'details' must be private and have accessor methods. |
46
|
|
| Missing a Javadoc comment. |
47
|
|
| Variable 'locked' must be private and have accessor methods. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| Variable 'disabled' must be private and have accessor methods. |
48
|
|
| Missing a Javadoc comment. |
49
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Missing a Javadoc comment. |
60
|
|
| Parameter id should be final. |
60
|
|
| 'id' hides a field. |
60
|
|
| Expected an @return tag. |
68
|
|
| Method 'getUsername' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Method 'setUsername' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Parameter username should be final. |
72
|
|
| 'username' hides a field. |
72
|
|
| Expected an @return tag. |
80
|
|
| Method 'getPassword' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Method 'setPassword' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Missing a Javadoc comment. |
84
|
|
| Parameter password should be final. |
84
|
|
| 'password' hides a field. |
84
|
|
| Expected an @return tag. |
91
|
|
| Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
| Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
| Missing a Javadoc comment. |
95
|
|
| Parameter firstName should be final. |
95
|
|
| 'firstName' hides a field. |
95
|
|
| Expected an @return tag. |
102
|
|
| Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
| Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
| Missing a Javadoc comment. |
106
|
|
| Parameter lastName should be final. |
106
|
|
| 'lastName' hides a field. |
106
|
|
| Method 'getFullName' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
| Missing a Javadoc comment. |
110
|
|
| Expected an @return tag. |
125
|
|
| Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. |
125
|
|
| Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Missing a Javadoc comment. |
129
|
|
| Parameter email should be final. |
129
|
|
| 'email' hides a field. |
129
|
|
| Expected an @return tag. |
139
|
|
| Method 'getGroups' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
| Method 'setGroups' is not designed for extension - needs to be abstract, final or empty. |
143
|
|
| Missing a Javadoc comment. |
143
|
|
| Parameter groups should be final. |
143
|
|
| 'groups' hides a field. |
143
|
|
| Method 'addGroup' is not designed for extension - needs to be abstract, final or empty. |
147
|
|
| Missing a Javadoc comment. |
147
|
|
| Parameter group should be final. |
147
|
|
| Method 'isInGroup' is not designed for extension - needs to be abstract, final or empty. |
161
|
|
| Parameter group should be final. |
161
|
|
| Expected @param tag for 'group'. |
161
|
|
| Expected an @return tag. |
177
|
|
| Method 'getDetails' is not designed for extension - needs to be abstract, final or empty. |
177
|
|
| Method 'setDetails' is not designed for extension - needs to be abstract, final or empty. |
181
|
|
| Missing a Javadoc comment. |
181
|
|
| Parameter details should be final. |
181
|
|
| 'details' hides a field. |
181
|
|
| '||' should be on a new line. |
186
|
|
| '+' should be on a new line. |
188
|
|
| Line is longer than 80 characters. |
201
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
201
|
|
| Method 'addDetail' is not designed for extension - needs to be abstract, final or empty. |
203
|
|
| Parameter key should be final. |
203
|
|
| Parameter value should be final. |
203
|
|
| '||' should be on a new line. |
204
|
|
| '+' should be on a new line. |
206
|
|
| Method 'getDetail' is not designed for extension - needs to be abstract, final or empty. |
212
|
|
| Missing a Javadoc comment. |
212
|
|
| Parameter key should be final. |
212
|
|
| Expected an @return tag. |
220
|
|
| Method 'isLocked' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
| Method 'setLocked' is not designed for extension - needs to be abstract, final or empty. |
224
|
|
| Missing a Javadoc comment. |
224
|
|
| Parameter locked should be final. |
224
|
|
| 'locked' hides a field. |
224
|
|
| Expected an @return tag. |
232
|
|
| Method 'isDisabled' is not designed for extension - needs to be abstract, final or empty. |
232
|
|
| Method 'setDisabled' is not designed for extension - needs to be abstract, final or empty. |
236
|
|
| Missing a Javadoc comment. |
236
|
|
| Parameter disabled should be final. |
236
|
|
| 'disabled' hides a field. |
236
|
|
| Method 'getSystemRights' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
| Missing a Javadoc comment. |
240
|
|
| Method 'isAccountNonExpired' is not designed for extension - needs to be abstract, final or empty. |
244
|
|
| Missing a Javadoc comment. |
244
|
|
| '+' should be on a new line. |
247
|
|
| Method 'isAccountNonLocked' is not designed for extension - needs to be abstract, final or empty. |
252
|
|
| Missing a Javadoc comment. |
252
|
|
| Method 'getAuthorities' is not designed for extension - needs to be abstract, final or empty. |
256
|
|
| Missing a Javadoc comment. |
256
|
|
| 'groups' hides a field. |
257
|
|
| Method 'isCredentialsNonExpired' is not designed for extension - needs to be abstract, final or empty. |
268
|
|
| Missing a Javadoc comment. |
268
|
|
| '+' should be on a new line. |
270
|
|
| Method 'isEnabled' is not designed for extension - needs to be abstract, final or empty. |
275
|
|
| Missing a Javadoc comment. |
275
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
279
|
|
| Missing a Javadoc comment. |
279
|
|
| Parameter o should be final. |
279
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
296
|
|
| Missing a Javadoc comment. |
296
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
300
|
|
| Missing a Javadoc comment. |
300
|
|
| '+' should be on a new line. |
301
|
|
| '+' should be on a new line. |
302
|
|
| '+' should be on a new line. |
303
|
|
| '+' should be on a new line. |
304
|
|
| '+' should be on a new line. |
305
|
|
| '+' should be on a new line. |
306
|
|
| '+' should be on a new line. |
307
|
|
| Expected an @return tag. |
317
|
|
| Method 'getRightsManagementService' is not designed for extension - needs to be abstract, final or empty. |
317
|
|
| Method 'setRightsManagementService' is not designed for extension - needs to be abstract, final or empty. |
327
|
|
| Parameter rightsManagementService should be final. |
328
|
|
| 'rightsManagementService' hides a field. |
328
|
|
| Expected @param tag for 'rightsManagementService'. |
328
|
org/flowfuse/base/model/user/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/authentication/AuthenticationService.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
11
|
|
| interfaces should describe a type and hence have methods. |
13
|
|
| Line is longer than 80 characters. |
16
|
|
| Missing a Javadoc comment. |
16
|
|
| Redundant 'public' modifier. |
16
|
|
| 'static' modifier out of order with the JLS suggestions. |
16
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
16
|
org/flowfuse/base/services/authentication/implementation/AuthenticationServiceImpl.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
16
|
|
| First sentence should end with a period. |
20
|
|
| Line is longer than 80 characters. |
23
|
|
| 'static' modifier out of order with the JLS suggestions. |
23
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
23
|
|
| First sentence should end with a period. |
25
|
|
| Variable 'logger' must be private and have accessor methods. |
28
|
|
| Missing a Javadoc comment. |
30
|
|
| Variable 'userDao' must be private and have accessor methods. |
30
|
|
| Method 'authenticate' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter authentication should be final. |
32
|
|
| Redundant throws: 'AuthenticationException' is unchecked exception. |
33
|
|
| Method 'supports' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter aClass should be final. |
37
|
|
| Method 'getUserDao' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Method 'setUserDao' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Missing a Javadoc comment. |
45
|
|
| Parameter userDao should be final. |
45
|
|
| 'userDao' hides a field. |
45
|
org/flowfuse/base/services/authentication/implementation/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/authentication/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/filter/FilterManagementService.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - java.util.List. |
6
|
|
| Line is longer than 80 characters. |
12
|
|
| Line is longer than 80 characters. |
17
|
|
| Missing a Javadoc comment. |
17
|
|
| Redundant 'public' modifier. |
17
|
|
| 'static' modifier out of order with the JLS suggestions. |
17
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
17
|
|
| Missing a Javadoc comment. |
19
|
|
| Redundant 'public' modifier. |
19
|
org/flowfuse/base/services/filter/implementation/SimpleFilterManagementServiceImpl.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
19
|
|
| Line is longer than 80 characters. |
21
|
|
| First sentence should end with a period. |
23
|
|
| Line is longer than 80 characters. |
24
|
|
| 'static' modifier out of order with the JLS suggestions. |
24
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
24
|
|
| First sentence should end with a period. |
26
|
|
| Variable 'logger' must be private and have accessor methods. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Method 'getConfiguredFilters' is not designed for extension - needs to be abstract, final or empty. |
31
|
|
| Missing a Javadoc comment. |
31
|
|
| Comment matches to-do format 'TODO:'. |
32
|
|
| Line is longer than 80 characters. |
34
|
|
| Line is longer than 80 characters. |
35
|
|
| Line is longer than 80 characters. |
36
|
|
| Line is longer than 80 characters. |
37
|
|
| Method 'setApplicationContext' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter applicationContext should be final. |
41
|
|
| 'applicationContext' hides a field. |
41
|
|
| Redundant throws: 'BeansException' is unchecked exception. |
42
|
org/flowfuse/base/services/filter/implementation/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/filter/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/right/RightsManagementService.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Line is longer than 80 characters. |
20
|
|
| Missing a Javadoc comment. |
20
|
|
| Redundant 'public' modifier. |
20
|
|
| 'static' modifier out of order with the JLS suggestions. |
20
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
20
|
|
| First sentence should end with a period. |
22
|
|
| Expected an @return tag. |
28
|
|
| Redundant 'public' modifier. |
28
|
|
| Expected @param tag for 'user'. |
28
|
org/flowfuse/base/services/right/implementation/RightsManagementServiceImpl.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
18
|
|
| First sentence should end with a period. |
22
|
|
| Line is longer than 80 characters. |
23
|
|
| 'static' modifier out of order with the JLS suggestions. |
23
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
23
|
|
| First sentence should end with a period. |
25
|
|
| Variable 'logger' must be private and have accessor methods. |
26
|
|
| Expected an @return tag. |
33
|
|
| Method 'getSystemRights' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Parameter user should be final. |
33
|
|
| Expected @param tag for 'user'. |
33
|
org/flowfuse/base/services/right/implementation/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/right/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/user/UserManagementService.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
11
|
|
| Line is longer than 80 characters. |
16
|
|
| Missing a Javadoc comment. |
16
|
|
| Redundant 'public' modifier. |
16
|
|
| 'static' modifier out of order with the JLS suggestions. |
16
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
16
|
|
| Missing a Javadoc comment. |
18
|
|
| Redundant 'public' modifier. |
18
|
org/flowfuse/base/services/user/implementation/UserManagementServiceImpl.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
19
|
|
| Line is longer than 80 characters. |
21
|
|
| First sentence should end with a period. |
23
|
|
| Line is longer than 80 characters. |
26
|
|
| 'static' modifier out of order with the JLS suggestions. |
26
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
26
|
|
| First sentence should end with a period. |
28
|
|
| Variable 'logger' must be private and have accessor methods. |
31
|
|
| First sentence should end with a period. |
33
|
|
| Missing a Javadoc comment. |
38
|
|
| Method 'getUser' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Missing a Javadoc comment. |
40
|
|
| First sentence should end with a period. |
45
|
|
| Method 'loadUserByUsername' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Parameter username should be final. |
52
|
|
| Method 'setUserDao' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Parameter userDao should be final. |
68
|
|
| 'userDao' hides a field. |
68
|
|
| Expected @param tag for 'userDao'. |
68
|
|
| Expected an @return tag. |
78
|
|
| Method 'getUserDao' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Expected an @return tag. |
88
|
|
| Method 'getRightsManagementService' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
| Method 'setRightsManagementService' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
| Parameter rightsManagementService should be final. |
99
|
|
| 'rightsManagementService' hides a field. |
99
|
|
| Expected @param tag for 'rightsManagementService'. |
99
|
org/flowfuse/base/services/user/implementation/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/user/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
org/flowfuse/base/services/workflow/WorkflowService.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
23
|
|
| Missing a Javadoc comment. |
23
|
|
| Redundant 'public' modifier. |
23
|
|
| 'static' modifier out of order with the JLS suggestions. |
23
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
23
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
49
|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
61
|
|
| Missing a Javadoc comment. |
63
|
|
| Missing a Javadoc comment. |
65
|
|
| Missing a Javadoc comment. |
67
|
|
| Missing a Javadoc comment. |
69
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
73
|
|
| Missing a Javadoc comment. |
75
|
|
| Missing a Javadoc comment. |
77
|
|
| Missing a Javadoc comment. |
79
|
org/flowfuse/base/services/workflow/functions/StoreCommentsFunction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
7
|
|
| Line is longer than 80 characters. |
18
|
|
| Line contains a tab character. |
18
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
18
|
|
| Missing a Javadoc comment. |
18
|
|
| Parameter transientVars should be final. |
18
|
|
| Parameter args should be final. |
18
|
|
| Parameter ps should be final. |
18
|
|
| Line is longer than 80 characters. |
19
|
|
| Line contains a tab character. |
19
|
|
| Line contains a tab character. |
20
|
|
| Line is longer than 80 characters. |
21
|
|
| Line contains a tab character. |
21
|
|
| Line contains a tab character. |
22
|
|
| Line contains a tab character. |
23
|
org/flowfuse/base/services/workflow/functions/StorePayloadPreprocessor.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
9
|
|
| Line is longer than 80 characters. |
16
|
|
| Line is longer than 80 characters. |
22
|
|
| Line is longer than 80 characters. |
27
|
|
| Missing a Javadoc comment. |
27
|
|
| Redundant 'public' modifier. |
27
|
|
| 'static' modifier out of order with the JLS suggestions. |
27
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
27
|
|
| Expected an @return tag. |
37
|
|
| Redundant 'public' modifier. |
37
|
|
| Expected @param tag for 'payload'. |
37
|
org/flowfuse/base/services/workflow/functions/TraceStepDurationFunction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
18
|
|
| Line is longer than 80 characters. |
23
|
|
| Missing a Javadoc comment. |
23
|
|
| 'static' modifier out of order with the JLS suggestions. |
23
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
23
|
|
| Missing a Javadoc comment. |
26
|
|
| Variable 'logger' must be private and have accessor methods. |
26
|
|
| Line is longer than 80 characters. |
28
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
28
|
|
| Missing a Javadoc comment. |
28
|
|
| Parameter transientVars should be final. |
28
|
|
| Parameter args should be final. |
28
|
|
| Parameter ps should be final. |
28
|
|
| Empty statement. |
30
|
org/flowfuse/base/services/workflow/functions/implementation/StoreWorkItemFunction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
24
|
|
| Line is longer than 80 characters. |
29
|
|
| Missing a Javadoc comment. |
29
|
|
| 'static' modifier out of order with the JLS suggestions. |
29
|
|
| Name 'rcsid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
29
|
|
| Missing a Javadoc comment. |
32
|
|
| Variable 'logger' must be private and have accessor methods. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Missing a Javadoc comment. |
39
|
|
| Parameter transientVars should be final. |
39
|
|
| Parameter args should be final. |
39
|
|
| Parameter ps should be final. |
39
|
|
| 'if' is not followed by whitespace. |
49
|
|
| Missing a Javadoc comment. |
66
|
|
| Parameter args should be final. |
66
|
|
| '+' should be on a new line. |
80
|
|
| '+' should be on a new line. |
81
|
|
| '+' should be on a new line. |
84
|
|
| '+' should be on a new line. |
85
|
|
| '+' should be on a new line. |
86
|
|
| '+' should be on a new line. |
89
|
|
| '+' should be on a new line. |
90
|
|
| '+' should be on a new line. |
93
|
|
| '+' should be on a new line. |
94
|
|
| Method 'getWorkItemManagementService' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
| Missing a Javadoc comment. |
100
|
|
| Method 'setWorkItemManagementService' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
| Missing a Javadoc comment. |
104
|
|
| Parameter workItemManagementService should be final. |
105
|
|
| 'workItemManagementService' hides a field. |
105
|
org/flowfuse/base/services/workflow/functions/implementation/StoreWorkflowDataFunction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
24
|
|
| Line is longer than 80 characters. |
29
|
|
| Missing a Javadoc comment. |
29
|
|
| 'static' modifier out of order with the JLS suggestions. |
2
|
